-
-
Notifications
You must be signed in to change notification settings - Fork 150
Implement Wheel of Misfortune (secret simultaneous number choices) #7266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
6f4903a
11ac6c5
ef863dd
e40a0ca
5818148
fc6f628
c330b27
9253fba
491191e
7de3311
efd880b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9011,7 +9011,9 @@ pub fn synthesize_read_ahead(face: &mut CardFace) { | |
| Effect::Choose { | ||
| choice_type: ChoiceType::NumberRange { | ||
| min: 1, | ||
| max: final_chapter.min(u8::MAX as u32) as u8, | ||
| // CR 702.155b: the Saga states its own upper bound (the final | ||
| // chapter), so this range is genuinely bounded. | ||
| max: Some(final_chapter), | ||
| distinctness: crate::types::ability::NumberDistinctness::Repeatable, | ||
| }, | ||
| persist: true, | ||
|
|
@@ -23010,7 +23012,7 @@ mod devour_synthesis_tests { | |
| panic!("read-ahead ETB should choose a number"); | ||
| }; | ||
| // CR 702.155b + CR 714.2d: between one and the final chapter number (3). | ||
| assert_eq!((*min, *max), (1, 3)); | ||
| assert_eq!((*min, *max), (1, Some(3))); | ||
| assert!(*persist, "chosen number must persist for ChosenNumber"); | ||
|
Comment on lines
23014
to
23016
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Exercise the removed The test uses a final chapter number of Use a focused fixture with a final chapter number greater than 🤖 Prompt for AI Agents |
||
|
|
||
| let sub = execute | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.