Skip to content

chore(card-data): refresh MTGJSON token & subtype catalogs - #6928

Merged
matthewevans merged 1 commit into
mainfrom
chore/refresh-card-data-catalogs
Aug 2, 2026
Merged

chore(card-data): refresh MTGJSON token & subtype catalogs#6928
matthewevans merged 1 commit into
mainfrom
chore/refresh-card-data-catalogs

Conversation

@matthewevans

@matthewevans matthewevans commented Aug 2, 2026

Copy link
Copy Markdown
Member

Automated refresh of the engine-embedded card-data catalogs from the latest MTGJSON publish.

  • crates/engine/data/known-tokens.toml — named-token catalog (tokens-gen)
  • crates/engine/data/oracle-subtypes.json — creature-subtype vocabulary (oracle-gen --write-subtypes)
  • crates/engine/data/mtgjson-vintage — vintage write-gate stamp

Generated by PHASE_REFRESH_MTGJSON=1 scripts/gen-card-data.sh; the vintage gate only promotes catalogs when the MTGJSON input date advances, so this diff reflects a genuine upstream data change. Review, then let it auto-merge once CI is green.

Summary by CodeRabbit

  • New Features

    • Added metadata for numerous The Hobbit-themed cards and tokens, including Smaug, Bilbo’s Gambit, Dáin Ironfoot, goblins, and The Lonely Mountain.
    • Added references for newly supported token variants and related card records.
  • Data Updates

    • Updated the vintage card data to the latest available dataset date.

@matthewevans
matthewevans enabled auto-merge August 2, 2026 16:11
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@matthewevans, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d30bc211-3426-4de4-b183-c91b72e73a0c

📥 Commits

Reviewing files that changed from the base of the PR and between 0378f81 and 2ddbdc7.

📒 Files selected for processing (2)
  • crates/engine/data/known-tokens.toml
  • crates/engine/data/mtgjson-vintage
📝 Walkthrough

Walkthrough

The engine token catalog now includes Hobbit-related source cards, token metadata, and Scryfall references across repeated indexes. The MTGJSON vintage date changed from 2026-07-30 to 2026-08-02.

Changes

Hobbit token catalog

Layer / File(s) Summary
Add Hobbit source-card references
crates/engine/data/known-tokens.toml
Adds Hobbit card names to token indexes and adds source-card references with Scryfall identifiers.
Add Hobbit token metadata
crates/engine/data/known-tokens.toml
Adds metadata for Hobbit, army, creature, goblin, and transformed-face token sources.
Complete catalog propagation and vintage update
crates/engine/data/known-tokens.toml, crates/engine/data/mtgjson-vintage
Propagates remaining Hobbit source-card names through token indexes and updates the MTGJSON vintage date.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the refresh of the MTGJSON token and subtype catalogs described in the pull request objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch chore/refresh-card-data-catalogs
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/refresh-card-data-catalogs

Comment @coderabbitai help to get the list of available commands.

@matthewevans
matthewevans force-pushed the chore/refresh-card-data-catalogs branch from 0378f81 to 2ddbdc7 Compare August 2, 2026 18:41
@matthewevans
matthewevans disabled auto-merge August 2, 2026 18:45
@matthewevans
matthewevans merged commit b657ac0 into main Aug 2, 2026
13 checks passed
@matthewevans
matthewevans deleted the chore/refresh-card-data-catalogs branch August 2, 2026 18:45
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

Generated for head 2ddbdc7681e7d28bed9290fa08350a875b54bc0c.

Parse changes introduced by this PR

✓ No card-parse changes detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant