Skip to content

Fix potential freezing browser #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: Pharo14
Choose a base branch
from
Open

Fix potential freezing browser #1239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 12 additions & 15 deletions src/NewTools-FileBrowser/StFileSystemPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,25 +100,22 @@ StFileSystemPresenter >> bookmarksTreeTable [
]

{ #category : 'initialization' }
StFileSystemPresenter >> connectPresenters [
StFileSystemPresenter >> connectPresenters [
"Here we check that the window is displayed.
If it's not, that means this is a first opening so it should preserve the path selected by the user (through openOnLastDirectory preference, or defaultRoot: message send) and not to transmit the directory selection"

super connectPresenters.

treeNavigationSystem
transmitDo: [ : selection |
(self isDisplayed and: [ selection isNotNil ])
ifTrue: [ self updateWidgetWithFileReference: selection fileReference ] ].

bookmarksTreeTable whenSelectionChangedDo: [ :selection |
selection selectedItem ifNotNil: [ :selectedItem |
selectedItem isComposite ifFalse: [
self fileNavigationSystem openFolder: selectedItem location ] ] ].

self whenDisplayDo: [
self centered.
treeNavigationSystem expandPath: fileNavigationSystem currentDirectory ].

treeNavigationSystem transmitDo: [ :selection |
(self isDisplayed and: [ selection isNotNil ]) ifTrue: [
self updateWidgetWithFileReference: selection fileReference ] ].

bookmarksTreeTable whenSelectionChangedDo: [ :selection |
selection selectedItem ifNotNil: [ :selectedItem |
selectedItem isComposite ifFalse: [
self fileNavigationSystem openFolder: selectedItem location ] ] ].

self whenDisplayDo: [ self centered ]
]

{ #category : 'layout' }
Expand Down
Loading