Skip to content

Sindarin fixes and improvements #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jecisc merged 3 commits into from
Apr 4, 2025
Merged

Sindarin fixes and improvements #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1be6fc
Introducing Sindarin specific api to obtain the node to which a scrip…
StevenCostiou Apr 3, 2025
42c1093
Replacing calls to internal debugger state to sindarin API
StevenCostiou Apr 3, 2025
fff596d
Extended sindarin commands: enable/disable depending on context
StevenCostiou Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/NewTools-Debugger/StDebugger.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,8 @@ StDebugger >> buildToolbarMenus: menuBar withCommandsGroups: advancedCommandGrou
name: cmd name;
icon: (self iconNamed: cmd iconName);
description: cmd description;
action: [ cmd execute ] ] ].
action: [ cmd execute ];
enabled: cmd canBeExecuted ] ].

menuBar addGroup: [ :group |
group addItem: [ :item |
Expand Down
11 changes: 3 additions & 8 deletions src/NewTools-Sindarin-Commands/SindarinJumpToCaretCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,7 @@ SindarinJumpToCaretCommand class >> defaultName [
{ #category : 'execution' }
SindarinJumpToCaretCommand >> execute [

| targetNode |
self flag:
'Context should actually be a debugger or a sindarin debugger'.
self flag: 'Suspicious call to internal debugger UI state'.
targetNode := self context sindarinDebugger bestNodeFor:
self context code selectionInterval.
self context sindarinDebugger moveToNode: targetNode.
self context forceSessionUpdate.
self context sindarinDebugger moveToNode:
self context sindarinTargetNode.
self context forceSessionUpdate
]
10 changes: 3 additions & 7 deletions src/NewTools-Sindarin-Commands/SindarinSkipUpToCommand.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,8 @@ SindarinSkipUpToCommand class >> defaultName [

{ #category : 'hooks' }
SindarinSkipUpToCommand >> execute [
| targetNode |

self flag: 'Context should actually be a debugger or a sindarin debugger'.
self flag: 'Suspicious call to internal debugger UI state'.
targetNode := self context sindarinDebugger
bestNodeFor: self context code selectionInterval.
self context sindarinDebugger skipUpToNode: targetNode.

self context sindarinDebugger skipUpToNode:
self context sindarinTargetNode.
self context forceSessionUpdate
]
6 changes: 6 additions & 0 deletions src/NewTools-Sindarin-Tools/StDebugger.extension.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,9 @@ Extension { #name : 'StDebugger' }
StDebugger >> sindarinDebugger [
^ SindarinDebugger attachTo: self session
]

{ #category : '*NewTools-Sindarin-Tools' }
StDebugger >> sindarinTargetNode [

^ self sindarinDebugger targetNodeFor: self code selectionInterval
]
Loading