Test for doSeparatedBy #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ducasse
reviewed
Mar 29, 2025
| table := newTable | ||
| | newTable newSize | | ||
| newSize := (table isEmpty) ifTrue: [1] ifFalse: [2 * table size]. "Ensure it grows from 0" | ||
| newTable := Array new: newSize. |
There was a problem hiding this comment.
I do not understand why the new size is not double because it can have an impact on the grow efficiency
Ducasse
reviewed
Mar 29, 2025
| collection add: 2. "Duplicate" | ||
| collection add: 1. "Duplicate" | ||
|
|
||
| "Verify that collection size is correct (duplicates should not be counted)" |
There was a problem hiding this comment.
Can you split this test in two?
One test testDuplicatedObjectsAreNotAdded
One test testDoSeparatedBy
Ducasse
reviewed
Mar 29, 2025
| emptyCollection remove: 42. "Removing from empty set" | ||
| ]) on: Error do: [ :ex | errorFlagEmpty := true. ]. | ||
| self assert: errorFlagEmpty. "Ensure an error is raised for empty set" | ||
|
|
There was a problem hiding this comment.
Can you split the tests into two different ones.
One for the empty and non empty case.
Ducasse
reviewed
Mar 29, 2025
| CTSmallOrderedSet >> errorNotFound [ | ||
| self error: 'Not found' | ||
| ] | ||
|
|
||
| { #category : #'private ' } | ||
| { #category : 'private ' } |
There was a problem hiding this comment.
Can you add a comment stating that the 0 is returned to indicate that the element is not found.
Ducasse
reviewed
Mar 29, 2025
|
|
||
| { #category : 'testing' } | ||
| CTSmallOrderedSetTest >> testErrorNotFound [ | ||
| | collectionSet emptyCollection errorFlagEmpty errorFlagNonExistent errorFlagAlreadyRemoved | |
There was a problem hiding this comment.
Can you remove the unused temps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test covers the following:
@Ducasse, please review the PRs.
I have tried to cover all the missing tests you mentioned in the email.
Please let me if this works.
Thankyou!