Merge pull request #426 from pharmaverse/ophth_unit_tests

ophth unit test fixes
pharmaverse · Dec 14, 2024 · fb35f8b · fb35f8b
2 parents 2ac0f17 + 9eebf9a
commit fb35f8b
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 9 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: sdtmchecks
 Title: Data Quality Checks for Study Data Tabulation Model (SDTM) Datasets
-Version: 1.0.0
+Version: 1.0.0.01
 Authors@R: c(
     person(given="Will", 
            family="Harris",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,10 @@
+# sdtmchecks 1.0.0.01 "CRAN Try"
+
+## Refinements of existing data check functions
+
+* Updates to several ophthalmology related checks
+
+
 # sdtmchecks 1.0.0 "CRAN Try"
 
 

diff --git a/tests/testthat/test-check_ec_sc_lat.R b/tests/testthat/test-check_ec_sc_lat.R
@@ -11,7 +11,7 @@ test_that("Function returns true when no errors are present", {
                    SCTESTCD = c("ELIGEYE", "FOCID", "", "ELIGEYE", "FOCID", ""),
                    SCCAT    = c("STUDY EYE SELECTION", "STUDY EYE SELECTION", "",
                                 "STUDY EYE SELECTION", "STUDY EYE SELECTION", ""),
-                   SCORRES  = c("LEFT", "OS", "", "RIGHT", "OD", ""),
+                   SCSTRESC  = c("LEFT", "OS", "", "RIGHT", "OD", ""),
                    SCDTC    = "2021-01-01",
                    stringsAsFactors = FALSE)
 
@@ -47,7 +47,7 @@ test_that("Function returns false when errors are present", {
                    SCTESTCD = c("ELIGEYE", "FOCID", "", "ELIGEYE", "FOCID", ""),
                    SCCAT    = c("STUDY EYE SELECTION", "STUDY EYE SELECTION", "",
                                 "STUDY EYE SELECTION", "STUDY EYE SELECTION", ""),
-                   SCORRES  = c("LEFT", "OS", "", "RIGHT", "OD", ""),
+                   SCSTRESC  = c("LEFT", "OS", "", "RIGHT", "OD", ""),
                    SCDTC    = "2021-01-01",
                    stringsAsFactors = FALSE)
 
@@ -72,7 +72,7 @@ test_that("Function returns false when errors are present", {
 })
 
 
-test_that("Function returns false when errors are present", {
+test_that("Function returns false when missing required variables", {
 
   sc <- data.frame(USUBJID  = c(1,1,1,2,2,2,3),
                    SCTEST   = c("Eye Meeting Eligibility Criteria",
@@ -86,7 +86,7 @@ test_that("Function returns false when errors are present", {
                    SCCAT    = c("STUDY EYE SELECTION", "STUDY EYE SELECTION", "",
                                 "STUDY EYE SELECTION",
                                 "STUDY EYE SELECTION", "", "STUDY EYE SELECTION"),
-                   SCORRES  = c("LEFT", "OS", "", "RIGHT", "OD", "", "RIGHT"),
+                   SCSTRESC  = c("LEFT", "OS", "", "RIGHT", "OD", "", "RIGHT"),
                    SCDTC    = "2021-01-01",
                    stringsAsFactors = FALSE)
 

diff --git a/tests/testthat/test-check_oe_sc_lat_count_fingers.R b/tests/testthat/test-check_oe_sc_lat_count_fingers.R
@@ -10,7 +10,7 @@ test_that("Returns true when no errors present", {
                    SCTESTCD = c("ELIGEYE", "FOCID", "", "ELIGEYE", "FOCID", ""),
                    SCCAT    = c("STUDY EYE SELECTION", "STUDY EYE SELECTION", "", 
                                 "STUDY EYE SELECTION", "STUDY EYE SELECTION", ""),
-                   SCORRES  = c("LEFT", "OS", "", "RIGHT", "OD", ""),
+                   SCSTRESC  = c("LEFT", "OS", "", "RIGHT", "OD", ""),
                    SCDTC    = rep("2021-01-01", 6),
                    stringsAsFactors = FALSE)
 
@@ -44,7 +44,7 @@ test_that("Returns false when errors present - 1", {
                    SCTESTCD = c("ELIGEYE", "FOCID", "", "ELIGEYE", "FOCID", ""),
                    SCCAT    = c("STUDY EYE SELECTION", "STUDY EYE SELECTION", "", 
                                 "STUDY EYE SELECTION", "STUDY EYE SELECTION", ""),
-                   SCORRES  = c("LEFT", "OS", "", "RIGHT", "OD", ""),
+                   SCSTRESC  = c("LEFT", "OS", "", "RIGHT", "OD", ""),
                    SCDTC    = rep("2021-01-01", 6),
                    stringsAsFactors = FALSE)
 
@@ -81,7 +81,7 @@ test_that("Returns false when errors present - 2", {
                    SCCAT    = c("STUDY EYE SELECTION", "STUDY EYE SELECTION", "", 
                                 "STUDY EYE SELECTION", "STUDY EYE SELECTION", 
                                 "", "STUDY EYE SELECTION"),
-                   SCORRES  = c("LEFT", "OS", "", "RIGHT", "OD", "", "OS"),
+                   SCSTRESC  = c("LEFT", "OS", "", "RIGHT", "OD", "", "OS"),
                    SCDTC    = "2021-01-01",
                    stringsAsFactors = FALSE)
 
@@ -153,7 +153,7 @@ test_that("Returns false when expected column not present - 2", {
                    SCTESTCD = c("ELIGEYE", "FOCID", "", "ELIGEYE", "FOCID", ""),
                    SCCAT    = c("STUDY EYE SELECTION", "STUDY EYE SELECTION", "", 
                                 "STUDY EYE SELECTION", "STUDY EYE SELECTION", ""),
-                   SCORRES  = c("LEFT", "OS", "", "RIGHT", "OD", ""),
+                   SCSTRESC  = c("LEFT", "OS", "", "RIGHT", "OD", ""),
                    SCDTC    = rep("2021-01-01", 6),
                    stringsAsFactors = FALSE)