-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #30 Creating ADIS Workflow: Step 3 #52
Conversation
Tested derive_vars_dt function with missing days and/or months. Fine
Merge datasets by using derive_var_merged_character
Removed program from R folder.
Removed step 3 program from R folder. |
Hi @federicobaratin I fixed the issues with styler and linting fails. FYI @pharmaverse/admiralvaccines The lintr does not like commented out code and will fail. Also, best practice for PR names is to start with "Closes #Issue Number" and then put in a blurb about what the pull Request is doing. This makes finding it later if there is a pertinent discussion, reference, etc easier to find. You can change name by click edit in below screenshots and saving. |
Hi Ben! |
@bms63 Is all fine with this pull request? :) |
Yes all good will merge |
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()