Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #30 Creating ADIS Workflow: Step 3 #52

Merged
merged 7 commits into from
Feb 23, 2023
Merged

Conversation

federicobaratin
Copy link
Collaborator

@federicobaratin federicobaratin commented Feb 16, 2023

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue so that it closes after successful merging.
  • Address all merge conflicts and resolve appropriately.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

federicobaratin and others added 3 commits February 3, 2023 09:27
Tested derive_vars_dt function with missing days and/or months. Fine
Merge datasets by using derive_var_merged_character
@federicobaratin federicobaratin added the help wanted Extra attention is needed label Feb 16, 2023
@federicobaratin federicobaratin self-assigned this Feb 16, 2023
@federicobaratin federicobaratin changed the title 30 adt ady derivation@devel Closes #30 Feb 16, 2023
Removed program from R folder.
@federicobaratin
Copy link
Collaborator Author

Removed step 3 program from R folder.
Updated ADIS template in inst folder

@github-actions
Copy link

github-actions bot commented Feb 17, 2023

Code Coverage

Package Line Rate Health
admiralvaccine 0%
Summary 0% (0 / 39)

@bms63 bms63 changed the title Closes #30 Closes #30 Creating ADIS Workflow: Step ? Feb 18, 2023
@bms63
Copy link
Collaborator

bms63 commented Feb 18, 2023

Hi @federicobaratin I fixed the issues with styler and linting fails. FYI @pharmaverse/admiralvaccines The lintr does not like commented out code and will fail.

Also, best practice for PR names is to start with "Closes #Issue Number" and then put in a blurb about what the pull Request is doing. This makes finding it later if there is a pertinent discussion, reference, etc easier to find. You can change name by click edit in below screenshots and saving.

image

image

@federicobaratin federicobaratin changed the title Closes #30 Creating ADIS Workflow: Step ? Closes #30 Creating ADIS Workflow: Step 3 Feb 20, 2023
@federicobaratin
Copy link
Collaborator Author

Hi Ben!
Thanks a lot for your help.
Yeah, actually I forgot to update the title. I have updated it with the STEP number we are going to close.

@federicobaratin
Copy link
Collaborator Author

@bms63 Is all fine with this pull request? :)
Or do I need to fix something else?

@bms63
Copy link
Collaborator

bms63 commented Feb 23, 2023

@bms63 Is all fine with this pull request? :) Or do I need to fix something else?

Yes all good will merge

@bms63 bms63 merged commit 23a8b24 into devel Feb 23, 2023
@ahasoplakus ahasoplakus deleted the 30_adt_ady_derivation@devel branch December 21, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants