[performance] Avoid repeated invocation of callbacks with same value. #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store (approximation) of last propagated value and compare.
JanKoelzer
force-pushed
the
performance/noRepeatedPropagation
branch
from
d429e1b to
227323a
Compare
Contributor
Author
|
If #98 is a performance improvement, this PR will most likely be useless. |
Contributor
Author
|
Implemented in #145 by a different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store (approximation) of last propagated value and compare. Callbacks will only be called, if an actually refined value would be propagated. Costs of callback execution can be avoided, but overhead is needed to store propagated values.