Fix wrong SSL 2.0 version and remove SSL 1.0 (bug in older JA4 spec) #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix version for SSL 2.0 and remove version for SSL 1.0, porting a bug fix [1] made in the JA4 spec in August 2024. While here, also fix some versions mentioned in strings to match the code. SSL 2.0 [2][3] uses a version field of 0x0002, not 0x0200. SSL 1 never existed outside of Netscape, as the original design was iterated upon to become SSL 2 before the first public version of SSL. I don't think it's public knowledge what the version field for SSL 1.0 looked like, or if it even was two bytes large or at the same offset on the wire. Version field 0x0100, that nfdump is currently misattributing to SSL 1.0, was used by an early pre-RFC4347 implementation of DTLS in OpenSSL before 0.9.8f [2], when OpenSSL switched to the version field specified by RFC4347. [1] FoxIO-LLC/ja4#150 [2] https://www-archive.mozilla.org/projects/security/pki/nss/ssl/draft02.html [3] https://datatracker.ietf.org/doc/html/draft-hickman-netscape-ssl-00 [4] openssl/openssl@OpenSSL_0_9_8e...OpenSSL_0_9_8f
phaag
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
Thanks Daniel for the PR. SSL 1.0 has been taken deliberatly taken into the code space - just to see, if there are any strange SSL connection ab(using) old protocols. So far I have not come across those, so it's fine to get rid of SSL 1.0
Although I use to check all PR, I have unlimited trust in your SSL knowhow :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix version for SSL 2.0 and remove version for SSL 1.0, porting FoxIO-LLC/ja4#150, a bug fix made in the JA4 spec in August 2024. While here, also fix some versions mentioned in strings to match the code.
SSL 2.0 (draft spec) (draft rfc) uses a version field of 0x0002, not 0x0200. SSL 1 never existed outside of Netscape, as the original design was iterated upon to become SSL 2 before the first public version of SSL. I don't think it's public knowledge what the version field for SSL 1.0 looked like, or if it even was two bytes large or at the same offset on the wire.
Version field 0x0100, that nfdump is currently misattributing to SSL 1.0, was used by an early pre-RFC4347 implementation of DTLS in OpenSSL before 0.9.8f, when OpenSSL switched to the version field specified by RFC4347.
Caution
I did not perform any testing.