Reuse dependencies that have already been provided, and fetch dependencies from submodules #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the CMake config so that when dependencies have already been provided by the parent project either through
find_packageoradd_subdirectorythey are reused.This should resolve the issue reported in #9.
Additionally this PR changes how libenvpp dependencies are fetched. Previously they were fetched from the respective repository through cmake's FetchContent, which has the disadvantage that an internet connection is required during the configure step. Now dependencies are fetched from submodules with FetchContent, which means that internet is only required during cloning.