Turn schema tests into unit tests #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## cli #9 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 1 -1
Lines 80 43 -37
=========================================
- Hits 80 43 -37 ☔ View full report in Codecov by Sentry. |
It was a bit fussy to have them as integration tests, and that's not really what they are anyway. So move them into `src/tests` and otherwise rejigger things only enough for them to have access to the private stuff they need. Also move the test corpus into the top-level `corpus` directory. While at it, move the compiler module under valid, as it's only needed by the valid module and the unit tests. Remove it from the root module and instead load it publicly only for tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a bit fussy to have them as integration tests, and that's not really what they are anyway. So move them into
src/testsand otherwise rejigger things only enough for them to have access to the private stuff they need.Also move the test corpus into the top-level
corpusdirectory.While at it, move the compiler module under valid, as it's only needed by the valid module and the unit tests. Remove it from the root module and instead load it publicly only for tests.