pfsense haproxy frontend #1
Conversation
|
@opoplawski are you on discord/slack/something? |
|
othehunter on discord. |
| @@ -0,0 +1,163 @@ | |||
| # -*- coding: utf-8 -*- | |||
|
|
|||
| # Copyright: (c) 2021, Chris Morton, [email protected] | |||
There was a problem hiding this comment.
You may want to update the year range here.
| @@ -0,0 +1,139 @@ | |||
| # -*- coding: utf-8 -*- | |||
|
|
|||
| # Copyright: (c) 2021, Chris Morton, [email protected] | |||
| #!/usr/bin/python | ||
| # -*- coding: utf-8 -*- | ||
|
|
||
| # Copyright: (c) 2019, Frederic Bor <[email protected]> |
There was a problem hiding this comment.
You probably want to add yourself here.
| DOCUMENTATION = """ | ||
| --- | ||
| module: pfsense_haproxy_frontend | ||
| version_added: "0.6.0" |
| DOCUMENTATION = """ | ||
| --- | ||
| module: pfsense_haproxy_frontend_server | ||
| version_added: "0.6.0" |
| extaddr=dict(required=True, type='str'), | ||
| extaddr_port=dict(required=True, type='int'), | ||
| extaddr_ssl=dict(required=True, type='str'), |
There was a problem hiding this comment.
You really don't want anything other name the id field to be required, otherwise you break removal with just the id. Use required_if with state present.
| status=dict(required=True, type='str'), | ||
| desc=dict(required=True, type='str'), |
There was a problem hiding this comment.
You really don't want anything other name the id field to be required, otherwise you break removal with just the id. Use required_if with state present.
|
As an FYI - I'm doing a lot of work here: https://github.com/opoplawski/pfsensible-core/tree/module_base_extended to extend PFSenseModuleBase and write |
haproxy frontend changes.
may need updating if any of the base haproxy pfsense plugin has added new fields/etc.
looks like some of the comments/ still have references to the backend.
Will clean up.