Add disableZoom option to enable users to zoom lightbox #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imcvampire
approved these changes
Jun 16, 2021
|
Thanks! |
|
@imcvampire Could you please release a npm version for this change? I found that the current 7.2.0 version on npm doesn't support it |
|
@pexea12 Please check this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users cannot zoom images in vue-image-lightbox because hammer.js blocks the events.
This Pull Request adds
disableZoomoption to enable users to do it.Taking backward compatibility into consideration, the default value of
disableZoomis set totrueref: #78