-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Argo backend #19
Merged
Merged
Changes from 22 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
47eda1c
add: subparser for argoize
Nilabhra 828e6d5
add: Nikhil's changes.
Nilabhra 5c72277
feat: generating workflow name using output file name.
Nilabhra c394308
feat: function to create Argo template from node.
Nilabhra 09f1c1c
chore: added docstring.
Nilabhra e42223c
chore: added comments.
Nilabhra 35cb1be
feat: setting the env vars before generation of the argo yaml.
Nilabhra 0b35916
feat: function to generate NFS volume specs for K8s.
Nilabhra c1ff95a
feat: added support for mounting NFS volumes.
Nilabhra d579f24
fix: using absolute path for the NFS mount paths.
Nilabhra 64396a3
fix: typo.
Nilabhra 1a7c0a9
feat: function for generating Argo templates for PIRlib Graph objects.
Nilabhra b901d3b
chore: added comments.
Nilabhra 6052ae4
feat: enabled creation of DAG tasks.
Nilabhra fcc6768
chore: added Argo specific refactoring.
Nilabhra 6316c87
chore: refactored argo task names.
Nilabhra 8a9b5fd
fix: files cannot be mounted as volumes in Argo/K8s.
Nilabhra 95fd3dd
chore: removed redundant module.
Nilabhra d339da2
chore: debugging code.
Nilabhra 1bc1cea
chore: optimized docker image generation.
Nilabhra 99912ef
add: dockerignore file to prevent copying of unnecessary files.
Nilabhra d552227
fix: missing volume mount.
Nilabhra a1c26c9
chore: reverted to original formatting.
Nilabhra 46b3ca1
chore: removed spurious code.
Nilabhra ee19634
chore: increased black linelength to 100.
Nilabhra 31c542a
Multistep pipeline support for Argo (#1)
Nilabhra 2a60ba2
fix: type annotation.
Nilabhra 49d1000
add: WIP files for one step execution of the wiki_parse pipeline.
Nilabhra 01d33ff
fix: type annotation.
Nilabhra 557d82b
add: WIP files for one step execution of the wiki_parse pipeline.
Nilabhra 332f345
feat: wiki_parse example running as a single step.
Nilabhra cd51aab
fix: merge conflicts.
Nilabhra 5045d4d
feat: PIRlib pipeline for parsing the sample Wikipedia data.
Nilabhra 8995742
chore: renamed input directory.
Nilabhra 2b8c8f6
add: input files.
Nilabhra d695521
add: shell file to download the full dbpedia dump.
Nilabhra 9ad7382
add: scripts to run the PIRlib pipeline on the entire dbpedia dump.
Nilabhra c9fce68
chore: code cleanup.
Nilabhra ead051c
chore: removed unneeded imports.
Nilabhra 367330a
feat: enabled parallel downloading of Wikipedia dumps.
Nilabhra 355d6c1
add: readme containing usage instructions.
Nilabhra 4e64fa4
Merge pull request #2 from Nilabhra/forte-wiki-parser
Nilabhra f082adb
Revert "Forte `wiki_parser`"
Nilabhra 7fa241f
Merge pull request #3 from Nilabhra/revert-2-forte-wiki-parser
Nilabhra 66dea30
Merge pull request #4 from Nilabhra/forte
Nilabhra ce78767
Revert "add: `wiki_parser` example from Forte"
Nilabhra 793c048
Merge pull request #5 from Nilabhra/revert-4-forte
Nilabhra f584c95
feat: raising exception if required env vars are not defined.
Nilabhra 6dbb27a
chore: refactored inp_name to inp_id.
Nilabhra 2f00467
chore: reformatted shell command.
Nilabhra 333b4d2
chore: reverted to inclusion of setting PYTHONPATH in the image.
Nilabhra c17156a
feat: prepending env of python to .
Nilabhra 1ad74fe
feat: changed base image to continuumio/miniconda3.
Nilabhra 535fa13
add: generated YAML files.
Nilabhra c4510c8
chore: incoporated PR feedback.
Nilabhra d23ca89
fix: conflicts.
Nilabhra 2d65765
add: Usage instructions.
Nilabhra 679bbf1
Merge branch 'argo-multistep'
Nilabhra bc9d923
chore: added Argo example to the main README.rst.
Nilabhra 99386f6
chore: updated documentation.
Nilabhra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
* | ||
!example/yaml | ||
!example/*py | ||
!bin | ||
!pirlib |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
EXAMPLEDIR=$(dirname $0) | ||
ROOTDIR=$EXAMPLEDIR/.. | ||
|
||
### Module 1: Docker_Packaging | ||
python $ROOTDIR/bin/pircli dockerize \ | ||
--auto $ROOTDIR \ | ||
--pipeline example.example:train_pipeline \ | ||
--output $EXAMPLEDIR/package_argo.yml \ | ||
--flatten | ||
|
||
# Convert EXAMPLEDIR to absolute path since docker can't bind-mount relative paths. | ||
EXAMPLEDIR=$([[ $EXAMPLEDIR = /* ]] && echo "$EXAMPLEDIR" || echo "$PWD/${EXAMPLEDIR#./}") | ||
|
||
### Module 2: Argoize_Module | ||
INPUT_train_dataset=$EXAMPLEDIR/inputs/train_dataset \ | ||
INPUT_translate_model=$EXAMPLEDIR/inputs/ \ | ||
INPUT_sentences=$EXAMPLEDIR/inputs/sentences \ | ||
OUTPUT=$EXAMPLEDIR/outputs \ | ||
NFS_SERVER=k8s-master.cm.cluster \ | ||
python $ROOTDIR/bin/pircli generate $EXAMPLEDIR/package_argo.yml \ | ||
--target pirlib.backends.argo_batch:ArgoBatchBackend \ | ||
--output $EXAMPLEDIR/argo-train.yml | ||
|
||
# Run the Argo workflow | ||
argo submit -n argo --watch $EXAMPLEDIR/argo-train.yml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH,
—auto $ROOTDIR
is a bit confusing.May be something like this will be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!