Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use any v5 version of actions/setup-python #200

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Use any v5 version of actions/setup-python #200

merged 4 commits into from
Oct 28, 2024

Conversation

peterbe
Copy link
Owner

@peterbe peterbe commented Oct 28, 2024

No description provided.

@peterbe
Copy link
Owner Author

peterbe commented Oct 28, 2024

@hartwork ?

@hartwork
Copy link
Collaborator

@hartwork ?

@peterbe please see #201 (review)

hartwork
hartwork approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterbe Thanks for splitting #202 off of this!

I'm approving now based on…

  • your conscious decision to fully trust future changes to actions/checkout over time
  • my hope that you will either squash the three commits before merge or use squash merge for this pull request 🙏

@hartwork hartwork mentioned this pull request Oct 28, 2024
Merged
@peterbe peterbe merged commit 3d29a3c into master Oct 28, 2024
10 checks passed
@peterbe peterbe deleted the use-any-v5-version-of-actionssetup-python branch October 28, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartwork hartwork hartwork approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterbe @hartwork