WIP: Tiling support - #105
Open
petar-v wants to merge 6 commits into
Open
Conversation
petar-v
force-pushed
the
horizontal-vertical
branch
from
April 15, 2025 01:30
a05529a to
423e9b3
Compare
petar-v
force-pushed
the
horizontal-vertical
branch
from
April 15, 2025 03:18
423e9b3 to
1013270
Compare
petar-v
commented
Apr 15, 2025
| export const attachSettingsListeners = (settings, listener) => { | ||
| settings.connect(`changed::${GRADIENT_DIRECTION}`, listener); | ||
| settings.connect(`changed::${MAXIMIZED_BEHAVIOR}`, listener); | ||
| settings.connect('changed::maximization-type', listener); |
Owner
Author
There was a problem hiding this comment.
Fix constant and we can do a loop here.
petar-v
commented
Apr 15, 2025
| windowMaximizeState === HORIZONTAL || | ||
| windowMaximizeState === BOTH || isFullScreen(window); | ||
| default: | ||
| return windowMaximizeState === BOTH; |
petar-v
commented
Apr 15, 2025
| this.emitStateChange(); | ||
| }; | ||
|
|
||
| const forceStateChangeEmission = () => emitStateChange(true); |
petar-v
commented
Apr 15, 2025
| this.display | ||
| .list_all_windows() | ||
| .filter(isMaximized) | ||
| .filter(window => isMaximized(window, this.maximizationType)) |
Owner
Author
There was a problem hiding this comment.
bring in the ismaximized in scope so it can read this.
petar-v
commented
Apr 15, 2025
| const config = getConfig(settings); | ||
| applyGradientStyle(config, this.path); | ||
|
|
||
| // For other behaviors, we need to track window states |
Owner
Author
There was a problem hiding this comment.
add a check if we're using a simple gradient and return if so.
petar-v
commented
Apr 15, 2025
| const config = getConfig(this._settings); | ||
|
|
||
| // Set the maximization type from settings | ||
| this.windowEvents.setMaximizationType(config.maximizationType); |
Owner
Author
There was a problem hiding this comment.
this should not be there wtf
petar-v
commented
Apr 15, 2025
| new MaximizationType(gettext('Vertically only'), MAXIMIZATION_TYPE.VERTICAL), | ||
| new MaximizationType(gettext('Horizontally only'), MAXIMIZATION_TYPE.HORIZONTAL), | ||
| new MaximizationType(gettext('Any of these'), MAXIMIZATION_TYPE.ANY) | ||
| ].forEach(type => maximizationTypeModel.append(type)); |
Owner
Author
There was a problem hiding this comment.
those should be better options and explain what this setting does.
…finition # Conflicts: # src/config.js # src/events/windowEvents.js # src/extension.js
petar-v
force-pushed
the
horizontal-vertical
branch
from
April 16, 2025 06:40
1013270 to
d2788b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.