Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for modules that like to access index.php directly #261

Closed
wants to merge 1 commit into from
Closed

Add handling for modules that like to access index.php directly #261

wants to merge 1 commit into from

Conversation

tdm4
Copy link

@tdm4 tdm4 commented Sep 15, 2016

For example, autocomplete taxonomy wants to access index.php and cannot. This rewrites the URL so it can. Also handles Drupal security issue people experienced earlier in the year.

Relates to issue (#241)

@tdm4
Copy link
Author

tdm4 commented Sep 15, 2016

@perusio not sure if you want it to return 404 if there are no arguments to index.php, or have it try via drupal handler.

@emjayess
Copy link

Could you please provide a link to the taxonomy autocomplete module project page that you are referencing? And does this patch address Drupal 7 configuration?

@tdm4
Copy link
Author

tdm4 commented Sep 15, 2016

Hi @emjayess this is from Drupal 7 core code: https://www.drupal.org/node/854216
This addresses Drupal 7 configuration. I'm not sure about Drupal 6. Have nothing to test that code on.

@tdm4
Copy link
Author

tdm4 commented Sep 15, 2016

OK maybe the title is was wrong. The drupal core code has autocomplete that accesses index.php directly. Also the patch for https://www.drupal.org/SA-CORE-2015-003 affected things too.
I'm not a drupal developer, just a sysadmin.

@iryston
Copy link
Contributor

iryston commented Oct 22, 2016

@tdm4 this commit doesn't works at my server.
I still receive an error.

An AJAX HTTP error occurred.
HTTP Result Code: 404
Debugging information follows.
Path: http://www.example.com/index.php?q=taxonomy/autocomplete/field_subjects
StatusText: Not Found
ResponseText:
404 Not Found
404 Not Found
nginx

@iryston
Copy link
Contributor

iryston commented Oct 24, 2016

To prevent allowing direct access to index.php is written a little module Autocomplete Unblock
The sandbox project is located at https://www.drupal.org/sandbox/irystonnet/2821464

Opened issue on Drupal.org Project applications https://www.drupal.org/node/2821473

To use it just clone to modules directory and enable.

git clone --branch 7.x-1.x https://git.drupal.org/sandbox/iryston.net/2821464.git autocomplete_unblock

@acrolink
Copy link

Would you please confirm that this issue cannot be fixed by some modification to the Nginx configuration files provided by drupal-with-nginx repo, without the need to install the above mentioned sandbox Drupal module? Thank you.

@iryston
Copy link
Contributor

iryston commented Mar 22, 2017

@acrolink this issue can be fixed as described in this comment
But, I don't think that allowing direct access to index.php is the preferred choice.

@tdm4 tdm4 closed this Apr 17, 2017
@tdm4
Copy link
Author

tdm4 commented Apr 17, 2017

Closing this as an agreement cannot be reached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants