-
Notifications
You must be signed in to change notification settings - Fork 11
fix -j and -g problems #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Hossein Naghdbishi <[email protected]>
Co-authored-by: Hossein Naghdbishi <[email protected]>
) Co-authored-by: Hossein Naghdbishi <[email protected]>
…lgorithm Co-authored-by: Hossein Naghdbishi <[email protected]>
Co-authored-by: Hossein Naghdbishi <[email protected]>
Co-authored-by: Hossein Naghdbishi <[email protected]>
|
The leap check function has two parts. The first is using the official data to simply get the leap status based on a table can be found here |
|
I have added the file The logic of the new |
|
I tried several times to get to this one and merge it. but it changes everything in one single PR and every time I get to it, I decide to simply ignore it since it is too much. |
|
Thanks for your response. Also, the commit messages are telling, and this pull request is made up of several commits. Feel free to ask about any of our changes and we'll happily respond. |
|
Hello,
Based on your friends reaction in mastadon, i feel like asking for fix is
not an option.
BUT if you want and you don't feel like i am wasting your time, please fix
the leap year issue first in a different pr. Just the leap year issue.
Thanks
…On Fri, Sep 26, 2025, 8:33 PM Amir Arsalan Yavari ***@***.***> wrote:
*arsalanyavari* left a comment (persiancal/jcal#37)
<#37 (comment)>
Thanks for your response.
This bug is also caused by an error in calculating the leap years.
Therefore the pull request to fix it requires all the changes we have made.
Also, the commit messages are telling, and this pull request is made up of
several commits.
Feel free to ask about any of our changes and we'll happily respond.
—
Reply to this email directly, view it on GitHub
<#37 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHEJ43OHJKEEENKH5HWD2D3UWBHDAVCNFSM6AAAAAB4JWYDXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMZZHE3DOMZUGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
fix the #11, #33 and #36 issues