Clean up Automake files #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable is nowhere assigned nor defined, not in the codes, not even in the docs. This can be added back when documented thoroughly.
This macro almost does nothing. Consult https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html
Users can opt in optimization by setting CFLAGS as it is the norm. There is no obvious reason why this must be forced on the users so unless documented, this must not be the case.
As for other flags, this is hardcoded for no documented reason. This, indeed, may change the program behaviour and lead to incorrect results but unless documented correctly or tested rigorously, is better removed.
This only outputs warnings which are concerns for developers rather than the end user. It clutters the output of compilation when not in development and even then, it is not always useful. Generally, this should signify that hardcoded optional flags are not favored in this style.
It is not documented why `_LARGEFILE_SOURCE` is used. A close guess is to prevent Y2038. According to Feature Test Macros[1], to prevent that, `_TIME_BITS=64` should be used which works only if `_FILE_OFFSET_BITS=64` is set as well. Hence this replacement is made. [1]: https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html#Feature-Test-Macros
Spacing before and after slashes, also how a line should be split is not edited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented in detail in commits and descriptions.
As with before, this should not change the behavior and builds with no problem. Written with Automake (GNU) 1.17 in mind.
In an overview:
In one instance,
configure.acis touched since it cannot be cleaned in isolation. The programs are removed since presumably they are always in modern computers at least according to GNU books and standards.