[BUGFIX] Partial table cell settings - gauge chart and range function#645
[BUGFIX] Partial table cell settings - gauge chart and range function#645mixturesolutions wants to merge 3 commits into
Conversation
mixturesolutions
force-pushed
the
snapshot/table-fix-test
branch
3 times, most recently
from
f1555e2 to
8dcea73
Compare
- gauge chart fixed in cell - gauge chart colors aligned with cell settings - range function debugged to allow only number (letters except e(used as scientific notation) cannot be entered instead of returning NaN) - range function allow decimals not just integers Signed-off-by: Iris Ye <[email protected]>
mixturesolutions
force-pushed
the
snapshot/table-fix-test
branch
from
8dcea73 to
8af9e34
Compare
ibakshay
left a comment
ibakshay
left a comment
There was a problem hiding this comment.
Thank you for the PR! Looks solid. left a small comment.
| /> | ||
| </Box> | ||
| <Typography variant="body2" sx={{ minWidth: 52, textAlign: 'right' }}> | ||
| {value.toFixed(2)} ms |
There was a problem hiding this comment.
Please remove the hard-coded ms unit. The unit should come from the column setting.
There was a problem hiding this comment.
Thank you Akshay for the review. Newest commit should solve the issue.
mixturesolutions
force-pushed
the
snapshot/table-fix-test
branch
from
3730c3a to
8af9e34
Compare
…ith Gauge units aligning to column format Signed-off-by: Iris Ye <[email protected]>
|
@mixturesolutions looks like your PR is a partial implem of perses/perses#3292 - partial as only applies to GaugeChart, right? If this statement is correct could you please rephrase your PR title & description as it's currently not well reflecting what the change is about IMHO |
Co-authored-by: Akshay Iyyadurai Balasundaram <[email protected]> Signed-off-by: Iris Ye <[email protected]>
mixturesolutions
changed the title
@AntoineThebaud that is correct. I have rephrased the PR title. For the description, I was refering to the issue I proposed myself that is a more detailed reference of the problems I faced and how it leads to the four bullet points I have:
|
3 participants
Description
This PR fixes/implements the proposals from this perses/perses##3969
Screenshots
Prev:
With PR:
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes