[ENHANCEMENT] remove unnecessary finalizers in favor of existing owner refereces#400
Merged
[ENHANCEMENT] remove unnecessary finalizers in favor of existing owner refereces#400
Conversation
…r refereces Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
jgbernalp
force-pushed
the
remove-finalizers
branch
from
bd19529 to
9ccc372
Compare
slashpai
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes unnecessary finalizers from Perses resources in favor of using the existing owner references. Existing finalizers are stripped during reconciliation so upgraded resources can be deleted cleanly. The finalizer constant, RBAC permissions, and migration code will be removed in a future release.
Type of change
FEATURE(non-breaking change which adds functionality)ENHANCEMENT(non-breaking change which improves existing functionality)BUGFIX(non-breaking change which fixes an issue)BREAKINGCHANGE(fix or feature that would cause existing functionality to not work as expected)DOC(documentation only)IGNORE(tooling, build system, CI, etc.)Verification
Checklist