[IGNORE] Add workflow_dispatch for operatorhub release and enforce tag-only refs#399
Open
slashpai wants to merge 1 commit intoperses:mainfrom
Open
[IGNORE] Add workflow_dispatch for operatorhub release and enforce tag-only refs#399slashpai wants to merge 1 commit intoperses:mainfrom
slashpai wants to merge 1 commit intoperses:mainfrom
Conversation
slashpai
force-pushed
the
operator-hub-wf
branch
2 times, most recently
from
7f64956 to
52c064b
Compare
…g-only refs Signed-off-by: Jayapriya Pai <[email protected]>
jgbernalp
reviewed
May 7, 2026
| TAG="${RELEASE_REF_INPUT#refs/tags/}" | ||
| VERSION="${TAG#v}" | ||
|
|
||
| if [ -z "${TAG}" ]; then |
Contributor
There was a problem hiding this comment.
I think here we are trying to check if this is empty, but this always has content even if RELEASE_REF_INPUT is empty, right?
jgbernalp
reviewed
May 7, 2026
| exit 1 | ||
| fi | ||
|
|
||
| if ! git ls-remote --exit-code --tags "https://github.com/${GITHUB_REPOSITORY}.git" "refs/tags/${TAG}" >/dev/null; then |
Contributor
There was a problem hiding this comment.
this failure can also be that the repo is unreachable, networking error for example. But the error message will still say the tag does not exist...
jgbernalp
reviewed
May 7, 2026
|
|
||
| - name: Copy bundle to versioned directory | ||
| run: | | ||
| VERSION="${{ steps.prepare_release.outputs.version }}" |
Contributor
There was a problem hiding this comment.
should we use env like in line 111?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related-to: #350
Type of change
FEATURE(non-breaking change which adds functionality)ENHANCEMENT(non-breaking change which improves existing functionality)BUGFIX(non-breaking change which fixes an issue)BREAKINGCHANGE(fix or feature that would cause existing functionality to not work as expected)DOC(documentation only)IGNORE(tooling, build system, CI, etc.)Verification
Checklist