Skip to content

[IGNORE] fix generate-changelog inserting entries at wrong position #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slashpai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[IGNORE] fix generate-changelog inserting entries at wrong position #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions scripts/generate-changelog/generate-changelog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
package main

import (
"bufio"
"bytes"
"flag"
"fmt"
Expand Down Expand Up @@ -48,27 +47,13 @@ func generateChangelog(clog *changelog.Changelog, version string) string {
}

func Write(clog *changelog.Changelog, version string) {
f, err := os.Open("CHANGELOG.md")
existingContent, err := os.ReadFile("CHANGELOG.md")
if err != nil {
logrus.WithError(err).Fatal("unable to open the file CHANGELOG.md")
logrus.WithError(err).Fatal("unable to read the file CHANGELOG.md")
}
fileScanner := bufio.NewScanner(f)
fileScanner.Split(bufio.ScanLines)
var buffer bytes.Buffer
i := 0
for fileScanner.Scan() {
buffer.WriteString(fileScanner.Text())
buffer.WriteString("\n")
i++
if i == 1 {
// inject the new changelog entries after the title
buffer.WriteString("\n")
buffer.WriteString(generateChangelog(clog, version))
}
}
if closeErr := f.Close(); closeErr != nil {
logrus.WithError(closeErr).Fatal("unable to close the file CHANGELOG.md")
}
buffer.WriteString(generateChangelog(clog, version))
buffer.Write(existingContent)
if writeErr := os.WriteFile("CHANGELOG.md", buffer.Bytes(), 0600); writeErr != nil {
logrus.WithError(writeErr).Fatal("unable to inject the new changelog entries in CHANGELOG.md")
}
Expand Down