[BREAKINGCHANGE] Store Perses config in Secret instead of ConfigMap#325
Draft
slashpai wants to merge 1 commit into
Draft
[BREAKINGCHANGE] Store Perses config in Secret instead of ConfigMap#325slashpai wants to merge 1 commit into
slashpai wants to merge 1 commit into
Conversation
…erses#322) Migrate Perses server configuration from ConfigMap to Secret to preserve sensitive fields (database credentials, OAuth secrets) that were being masked by the secret.Hidden Go type as `<secret>`. - Add custom MarshalConfigYAML using reflection to bypass secret.Hidden masking and serialize actual values into the Secret - Add cleanupOldConfigMap to delete legacy ConfigMaps during migration - Update volume mounts from ConfigMapVolumeSource to SecretVolumeSource - Update RBAC: add configmaps get/list/delete for migration cleanup, add secrets full CRUD - Add integration test reproducing issue perses#206 scenario Fixes perses#206 Closes perses#322 Assisted-By: Cursor Signed-off-by: Jayapriya Pai <[email protected]>
slashpai
force-pushed
the
perses-config-as-secret
branch
from
79a22ac to
9e9ec1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #322
This will have more values once we have secretRef pattern implemented for sensitive fields #322 (comment), we can wait till thats implemented to proceed with this so we can have breaking change that time probably after current release
Description
Closes: #ISSUE-NUMBER
Type of change
FEATURE(non-breaking change which adds functionality)ENHANCEMENT(non-breaking change which improves existing functionality)BUGFIX(non-breaking change which fixes an issue)BREAKINGCHANGE(fix or feature that would cause existing functionality to not work as expected)DOC(documentation only)IGNORE(tooling, build system, CI, etc.)Verification
Checklist