fix: encode photos up to the 512 KiB image budget - #1691
Open
Chessing234 wants to merge 3 commits into
Open
Conversation
The protocol already allows 512 KiB images and Android encodes at 512px without a second squeeze. Crushing iOS JPEGs to 45 KB at 448px made photos unreadable on the same radio as voice notes.
A noisy 1600x1200 source must land above the old 45 KB crush, at or under FileTransferLimits.maxImageBytes, with a 512px long edge.
SwiftLint unused_closure_parameter fails the suite otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImageUtilscrushed JPEGs to 45 KB at 448px even thoughFileTransferLimits.maxImageBytesis already 512 KiB. Voice notes travel at that budget; Android encodes at 512px / q=85 with no extra squeeze.Test plan
swiftctypecheck ofImageUtils.swiftunder Swift 5 and 6xcodebuildtest suite — this machine has Command Line Tools only, no Xcode; CI coversprocessImage_usesThe512KiBBudgetInsteadOfCrushingTo45KB