fix: refuse an ambiguous nickname instead of picking the first peer - #1689
Open
Chessing234 wants to merge 1 commit into
Open
fix: refuse an ambiguous nickname instead of picking the first peer#1689Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
getPeerID(for:) and geohash geoNicknames.first(where:) returned the first match, so /msg and /block could hit the wrong person when two peers share a name. Accept an unsuffixed nick only when it is unique; otherwise require the people-list #xxxx suffix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnifiedPeerService.getPeerID(for:)and geohashgeoNicknames.first(where:)returned the first match, so/msgand/blockcould hit the wrong person when two peers shared a nickname.#xxxxsuffix.Test plan
swiftctypecheck ofNicknameLookup.swiftunder Swift 5 and 6NicknameLookup(unique, colliding,#xxxxsuffix, unknown)xcodebuildtest suite — this machine has Command Line Tools only, no Xcode; CI covers the newUnifiedPeerService/ChatPeerIdentityCoordinatortestsMade with Cursor