Skip to content

fix(geohash): publish currentGeohash writes to the threads that read it #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(geohash): publish currentGeohash writes to the threads that read it #895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/src/main/java/com/bitchat/android/nostr/GeohashRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,17 @@ class GeohashRepository(
// peerID alias -> nostr pubkey mapping for geohash DMs and temp aliases
private val nostrKeyMapping: MutableMap<String, String> = mutableMapOf()

// Current geohash in view
// Current geohash in view. Written from the UI thread when the user picks
// a channel and read from Nostr handler and timer threads - including from
// the @Synchronized methods below, which only see a published write if the
// write itself is synchronized. NotificationManager marks its copy of this
// state @Volatile for the same reason.
private var currentGeohash: String? = null

@Synchronized
fun setCurrentGeohash(geo: String?) { currentGeohash = geo }

@Synchronized
fun getCurrentGeohash(): String? = currentGeohash

@Synchronized
Expand Down