fix(cu): in findresult, check for exact eval by message id #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrain99
force-pushed
the
jfrain99/check-assignments-by-message-id-cu
branch
from
51012d6 to
b572f49
Compare
jfrain99
force-pushed
the
jfrain99/check-assignments-by-message-id-cu
branch
from
b572f49 to
4d3e8bf
Compare
jfrain99
requested review from
TillaTheHun0
and removed request for
TillaTheHun0
Comment on lines
22
to
+24
| return findEvaluation({ | ||
| processId: ctx.id, | ||
| to: ctx.to, | ||
| ordinate: ctx.ordinate, | ||
| cron: ctx.cron | ||
| messageId: ctx.messageId |
There was a problem hiding this comment.
There are cases where messageId will be undefined, like the case of requests to /cron and /dry-run.
Perhaps this should attempt to call findEvaluation iff messageId is provided?
|
Please continue to hold on this change, as it seems the ecosystem has coded to the existing behavior, and so we might need to keep it around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the CU was searching for old evaluations (
findEvaluation) through processId, timestamp, ordinate, cron. Now, only search by processId and messageId to find duplicate assignments.Closes #1091