temp: Store messages primarily by their signed ID #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves our position in an impactful trade-off space in a direction that we will not want to pursue long-term. It does, however, provide significant (as much as 2x, depending on circumstances) performance improvements that are valuable until PR #391 hits. Prior to this commit, the `hb_cache` system referenced all messages via their uncommitted ID, which is linked to from all committed IDs. Each commitment was then stored in the `commitments` key of this message. Upside: A consequence of this design is that reading one ID for a message (whether signed or unsigned) leads to all of the known commitments being available for use. Downside: This design reads _all_ commitments into memory every time a single message is read. While sometimes useful, this is not desirable behavior in all cases. #391 moves us forward with a long-term fix, but until that hits `edge` this PR provides immediate performance relief, while also leading to a modest increase in the size of caches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves our position in an impactful trade-off space in a direction that we will not want to pursue long-term. It does, however, provide significant (as much as 2x, depending on circumstances) performance improvements that are valuable until PR #391 hits.
Prior to this commit, the
hb_cachesystem referenced all messages via their uncommitted ID, which is linked to from all committed IDs. Each commitment was then stored in thecommitmentskey of this message.Upside: A consequence of this design is that reading one ID for a message (whether signed or unsigned) leads to all of the known commitments being available for use. Downside: This design reads all commitments into memory every time a single message is read.
While sometimes useful, this is not desirable behavior in all cases. #391 moves us forward with a long-term fix, but until that hits
edgethis PR provides immediate performance relief, while also leading to a modest increase in the size of caches.