fix: handle tag name clash on dev_codec_ans104 #392
+1,133
−646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesPiechota
force-pushed
the
fix/ans104-tag-clash-20250728
branch
from
b937593 to
b7cf10a
Compare
JamesPiechota
changed the title
JamesPiechota
force-pushed
the
fix/ans104-tag-clash-20250728
branch
from
eb1583d to
4ae636c
Compare
JamesPiechota
force-pushed
the
fix/ans104-tag-clash-20250728
branch
2 times, most recently
from
a6bb488 to
f4f7cff
Compare
New logic:
if any normalized #tx.tags tag clashes with either the L1 target or last_tx
then we resolve by:
1. sort all the keys such that: lowercase < Capitalized < all-other-casings < L1
2. base-layer TABM key is set to the first value from the sort
3. add an `original-target` or `original-anchor` to the commitments with the
L1 value
samcamwilliams
force-pushed
the
fix/ans104-tag-clash-20250728
branch
from
6b0a325 to
5e89e42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New logic:
if any normalized #tx.tags tag clashes with either the L1 target or last_tx then we resolve by:
original-targetororiginal-anchorto the commitments with the L1 value