Improve a11y test suite and add CI workflow#554
Draft
jamiefolsom wants to merge 15 commits intodevelopfrom
Draft
Improve a11y test suite and add CI workflow#554jamiefolsom wants to merge 15 commits intodevelopfrom
jamiefolsom wants to merge 15 commits intodevelopfrom
Conversation
Develop into master
v1.4.1 null geometry hotfix
v1.4.2 updates
v1.4.3 updates
v1.4.4 -- Adding web identifiers to record detail page
v1.4.5 Updates
v1.4.6 changes
v1.4.7 updates
✅ Deploy Preview for padp-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pss-scavenger-hunt ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for juel-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for gbof-c19nyc-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for libertos ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for juel-life ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for registro-project ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for juel-ancestry ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for gamepossible ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for universities-studying-slavery ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jamiefolsom
force-pushed
the
feature/a11y-test-improvements
branch
from
30fbe4d to
9b320be
Compare
Develop into master
`develop` into `master`
`develop` into `master`
- Fix path detail URL bug (posts/ → paths/) in a11y.test.ts - Filter axe-core to WCAG 2.0/2.1/2.2 AA rules only - Use soft assertions so all violations surface per page - Add manual-trigger GitHub Actions workflow (.github/workflows/a11y.yml) - Add test results report (docs/a11y-test-results.md) - Update CLAUDE.md with multi-tenant env var and TinaCMS gotchas
Covers web content (automated + manual), PDF accessibility checklist, and Playwright hybrid approach for automated PDF checks via download and pdf-lib/veraPDF inspection.
- Change NavDropdown trigger from div to button for valid aria-expanded - Add aria-label fallback on Sessions clear-all button for hydration timing - Wait for React hydration before scanning Sessions page - Guard detail_pages.models access when config has no detail pages
Column images in the page builder had no alt text support, causing critical image-alt a11y violations on pages using them.
jamiefolsom
force-pushed
the
feature/a11y-test-improvements
branch
from
9b320be to
7099360
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a11y.test.ts(posts/→paths/)expect.soft()so all violations surface per page without masking.github/workflows/a11y.yml)docs/a11y-test-results.md)CLAUDE.mdwith multi-tenant env var and TinaCMS gotchasTest results (USS content, chromium)
image-alt— tracked in #553)CI workflow usage
Trigger manually from Actions tab or:
Requires secrets:
CONFIG_URL,CONTENT_GITHUB_OWNER,CONTENT_GITHUB_REPO,CONTENT_GITHUB_BRANCH,CONTENT_GITHUB_PERSONAL_ACCESS_TOKEN,MONGODB_URI,MONGODB_NAME,MONGODB_COLLECTION_NAME,NEXTAUTH_SECRETTest plan
npx playwright test --project=chromiumpasses (1 expected failure: a11y: Banner images missing alt text (WCAG 1.1.1 Level A) #553)gh workflow run a11ysucceeds after secrets are set