Merged
Conversation
blms
approved these changes
Apr 9, 2026
Contributor
blms
left a comment
blms
left a comment
There was a problem hiding this comment.
Overall looks great! Just one tiny question about types.
| id: number, | ||
| geometry_json: string | ||
| geometry_json: string, | ||
| properties: string |
Contributor
There was a problem hiding this comment.
Should properties be a required string or an (optional?) object with certainty_radius as an optional key?
Contributor
Author
There was a problem hiding this comment.
Good question - I think at the point that the type is used (when the data is being transformed to go to the server), the JSON has been stringified, so that's why geometry_json is also a string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to store a certainty radius, in KM, at the top level of a place's geometry using a new
MapCertaintyControlcomponent.