PMM-14157 - Update MongoDB PBM backup alert template to use max_over_… #4690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time for last successful backup check - Modified the expression to calculate the age of the last successful backup using max_over_time for better accuracy over a 30-day window. - Updated the summary and description annotations to include cluster and replica set information for clearer context in alerts.
theTibi
requested review from
BupycHuk and
idoqo
and removed request for
a team
|
This mongodb PR is needed for this alert: percona/mongodb_exporter#1181 |
|
@catalinaadam PTAL messages |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #4690 +/- ##
=======================================
Coverage 44.56% 44.56%
=======================================
Files 363 363
Lines 45706 45706
=======================================
Hits 20369 20369
Misses 23677 23677
Partials 1660 1660
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…moving replica_set grouping. This change enhances clarity in the alerting logic while maintaining the focus on cluster-level backup status.
idoqo
approved these changes
Oct 20, 2025
…rmation from summary and description annotations. This change enhances clarity and focuses on the cluster-level backup status.
yurkovychv
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…time for last successful backup check
PMM-0
Link to the Feature Build: SUBMODULES-0
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: