-
Notifications
You must be signed in to change notification settings - Fork 182
PMM-14305 Fix ClickHouse dirty migration state #4651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ademidoff
wants to merge
8
commits into
v3
Choose a base branch
from
PMM-14305-fix-clickhouse-dirty-state
base: v3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7c157a to
d5914f6
Compare
d5914f6 to
acc18de
Compare
ademidoff
commented
Oct 12, 2025
| } | ||
|
|
||
| // Set returns derived context with set logrus entry with given request ID. | ||
| func Set(ctx context.Context, requestID string) context.Context { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was unused.
idoqo
approved these changes
Oct 13, 2025
BupycHuk
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-14305
Link to the Feature Build: SUBMODULES-4070
PR Summary
This pull request features the following changes:
github.com/pkg/errorspackage to the standard libraryerrorspackageError handling improvements:
github.com/pkg/errorswith the Go standard libraryerrorspackage in bothdb.goandmain.go, simplifying dependencies and modernizing error handling. [1] [2] [3] [4]Database migration robustness:
runMigrationsfunction indb.goto handle dirty migration states: if a migration fails and leaves the database dirty, it now attempts to force the migration version and re-run migrations, improving reliability during upgrades.Logger context API clarification:
Getinlogger.goto clarify thatSetEntry(notSet) must be called before retrieving a logger from context.Setfunction fromlogger.go, streamlining the logger context API to only useSetEntry.