PMM-13174 RBAC tests for PMM3 #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puneet0191
approved these changes
Jun 26, 2024
.github/workflows/fb-e2e-suite.yml
Outdated
| uses: ./.github/workflows/runner-e2e-tests-codeceptjs.yml | ||
| secrets: inherit | ||
| with: | ||
| pmm_server_image: ${{ inputs.pmm_server_image || 'perconalab/pmm-server:dev-latest' }} |
There was a problem hiding this comment.
is this the default flag for dev-latest in pmm3?
There was a problem hiding this comment.
Fixed tags for rbac and other pipelines that used old tags.
https://github.com/percona/pmm-qa/actions/runs/9676315706
# Conflicts: # .github/workflows/fb-e2e-suite.yml
yurkovychv
reviewed
Jun 27, 2024
.github/workflows/fb-e2e-suite.yml
Outdated
| pmm_client_image: ${{ inputs.pmm_client_image || 'perconalab/pmm-client:dev-latest' }} | ||
| pmm_server_image: ${{ inputs.pmm_server_image || 'perconalab/pmm-server:3-dev-latest' }} | ||
| pmm_client_version: ${{ inputs.pmm_client_version || '3-dev-latest' }} | ||
| pmm_client_image: ${{ inputs.pmm_client_image || 'perconalab/pmm-client:3-dev-latest' }} | ||
| pmm_qa_branch: ${{ inputs.pmm_qa_branch || 'main' }} |
There was a problem hiding this comment.
@peterSirotnak could you also change main to v3 for pmm_qa_branch and pmm_ui_tests_branch ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.