-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPXC-1544: Add basic Prometheus metrics for binlog-collector #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55e7c3f
to
4dff4fd
Compare
egegunes
requested changes
Jan 13, 2025
4dff4fd
to
d7aaded
Compare
egegunes
previously approved these changes
Jan 13, 2025
pooknull
previously approved these changes
Jan 13, 2025
gkech
reviewed
Jan 13, 2025
d7aaded
to
fbe5ab7
Compare
The following metrics have been added: - pxc_binlog_collector_success_total - pxc_binlog_collector_failure_total - pxc_binlog_collector_last_processing_timestamp - pxc_binlog_collector_last_upload_timestamp - pxc_binlog_collector_gap_detected_total
fbe5ab7
to
e6a5948
Compare
commit: e6a5948 |
gkech
approved these changes
Jan 14, 2025
egegunes
approved these changes
Jan 14, 2025
@s10 thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following metrics have been added:
pxc_binlog_collector_success_total
pxc_binlog_collector_failure_total
pxc_binlog_collector_last_processing_timestamp
pxc_binlog_collector_last_upload_timestamp
pxc_binlog_collector_gap_detected_total
Additionally, a simple /health endpoint has been added
CHANGE DESCRIPTION
Problem:
We don't have any prometheus metrics from pitr deployment, so the observability of binlog backups is quite limited.
Cause:
No prometheus metrics in binlog-collector application.
Solution:
Add prometheus metrics to binlog-collector application.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability