-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pt-kill Added new features that can support tidb #876
base: 3.x
Are you sure you want to change the base?
Conversation
suyestyle
commented
Oct 16, 2024
•
edited
Loading
edited
- The contributed code is licensed under GPL v2.0
- Contributor Licence Agreement (CLA) is signed
- util/update-modules has been ran
- Documentation updated
- Test suite update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test case and make "mysql" default value for the "db-type" parameter. You can find an example of how to do it in the definition of option recursion-method for pt-online-schema-change utility.
If you want to add rules to mysql clusters, you can do so
Or do this
If you want to add rules to tidb clusters, you can do so
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve my comments and add a test case. You will find examples in t/pt-kill.
@@ -4,6 +4,7 @@ | |||
# See "COPYRIGHT, LICENSE, AND WARRANTY" at the end of this file for legal | |||
# notices and disclaimers. | |||
|
|||
use DBI; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is auto-generated code. No change should be here.
I also do not understand why you need to explicitly import DBI for the code you propose.
|
||
type: string | ||
|
||
mysql; tidb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here should be the default value for mysql. Please check other options where the default value is defined.
How do I provide the use cases you're talking about. |
@suyestyle Please check CONTRIBUTING.md and files in t/pt-kill. |
Thank you for your patience. I have put my use case in the above answer, is there any problem with this way? I can't find any use case information here on t/pt-kill, a lot of it is code information. |