Merge pull request #907 from percona/remove_unused_variable_force_con…

…cat_enums Remove unused variable force_concat_enums
percona · Jan 14, 2025 · 6f62b4d · 6f62b4d
2 parents 0a98a81 + 1bec1fd
commit 6f62b4d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/bin/pt-online-schema-change b/bin/pt-online-schema-change
@@ -5865,8 +5865,6 @@ sub _nibble_params {
       );
       PTDEBUG && _d('Ascend params:', Dumper($asc));
 
-      my $force_concat_enums;
-
 
       my $from     = "$tbl->{name} FORCE INDEX(`$index`)";
       my $order_by = join(', ', map {$q->quote($_)} @{$index_cols});

diff --git a/bin/pt-table-checksum b/bin/pt-table-checksum
@@ -6686,8 +6686,6 @@ sub _nibble_params {
       );
       PTDEBUG && _d('Ascend params:', Dumper($asc));
 
-      my $force_concat_enums;
-
 
       my $from     = "$tbl->{name} FORCE INDEX(`$index`)";
       my $order_by = join(', ', map {$q->quote($_)} @{$index_cols});

diff --git a/lib/NibbleIterator.pm b/lib/NibbleIterator.pm
@@ -208,10 +208,6 @@ sub _nibble_params {
       );
       PTDEBUG && _d('Ascend params:', Dumper($asc));
 
-      # Check if enum fields items are sorted or not.
-      # If they are sorted we can skip adding CONCAT to improve the queries eficiency.
-      my $force_concat_enums;
-
       # Make SQL statements, prepared on first call to next().  FROM and
       # ORDER BY are the same for all statements.  FORCE IDNEX and ORDER BY
       # are needed to ensure deterministic nibbling.

diff --git a/util/update-modules b/util/update-modules
@@ -137,6 +137,10 @@ if [ ! -f $tool_file ]; then
    die "$tool_file does not exist"
 fi
 
+if [ -h $tool_file ]; then
+   die "$tool_file is a symbolic link"
+fi
+
 if [ -n "$(head -n 1 $tool_file | grep perl)" ]; then
    tool_lang="perl"
 else