PS-9193: JS Routines: killability/max_statement_time support. #5540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://perconadev.atlassian.net/browse/PS-9193 Improved handling of KILL and MAX_EXECUTION_TIME timeouts in connections running JS code. Special KILL handler in JS language component is now invoked when connection (or statement) executing JS code gets killed (due to KILL statement or due to reaching MAX_EXECUTION_TIME timeout). The handler calls V8 method aborting execution of JS code, allowing to terminate connection/statement without delays. To implement this a new service was added to SQL core which allows components to install/remove such KILL handlers for connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved handling of KILL and MAX_EXECUTION_TIME timeouts in connections running JS code.
JS language component now gets notified when connection (or statement)
executing JS code gets killed (due to KILL statement or due to reaching
MAX_EXECUTION_TIME timeout). The component calls V8 method aborting
execution of JS code, allowing to terminate connection/statement without
delays.