-
Notifications
You must be signed in to change notification settings - Fork 32
K8SPS-469 fix data-at-rest
tests
#1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Fixes restore failures on clusters with specified .spec.mysql.vaultSecretName
by updating the xtrabackup version parsing logic to handle additional output lines that were introduced in newer xtrabackup versions.
- Updated version parsing to filter for the specific "xtrabackup version" line before extracting version numbers
- Ensures compatibility with xtrabackup's new output format that includes additional log messages
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
commit: c7b78d3 |
DESCRIPTION
Problem:
Restores fail on clusters with specified
.spec.mysql.vaultSecretName
Cause:
xtrabackup started outputting an additional line when the command
xtrabackup --version
is executed:The
run-restore.sh
script uses this command to determine the xtrabackup version.Previously, it expected output such as 8.0 or 8.4, but now it receives an additional line, resulting in:
Solution:
Extract the line containing the
xtrabackup version
prefix and parse the version from that lineCHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability