-
Notifications
You must be signed in to change notification settings - Fork 32
K8SPS-469: more logs during storage validation #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds improved logging for storage validation during initialization of S3 and Azure storage clients. The changes enhance debugging capabilities by providing more informative error messages when storage validation fails.
- Enhanced error handling and logging for S3 bucket existence checks
- Added storage properties validation with logging for Azure clients
- Updated Azure client constructor to accept context parameter for logging
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
commit: 4b0df28 |
https://perconadev.atlassian.net/browse/K8SPS-469
DESCRIPTION
When S3 storage credentials are invalid, the response may be a
400 Bad Request
(on AWS) or a403 SignatureDoesNotMatch
/403 AccessDenied
(on MinIO).The operator now logs an additional message indicating that the credentials or permissions may be invalid.
This PR also adds credentials validation for Azure storage.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability