-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUD-869 Enhance Jenkinsfile to skip builds for specified non-trigger files #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptankov
requested review from
nmarukovich,
jvpasinatto,
eleo007,
hors,
egegunes,
inelpandzic and
pooknull
as code owners
December 12, 2024 11:18
ptankov
changed the title
Enhance Jenkinsfile to skip builds for specified non-trigger files
CLOUD-869 Enhance Jenkinsfile to skip builds for specified non-trigger files
Dec 12, 2024
…g for previous builds
egegunes
reviewed
Jan 2, 2025
egegunes
reviewed
Jan 8, 2025
egegunes
reviewed
Jan 8, 2025
eleo007
reviewed
Jan 8, 2025
commit: ef27572 |
egegunes
approved these changes
Jan 9, 2025
egegunes
approved these changes
Jan 9, 2025
eleo007
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Currently we start e2e test suite for every single PR without considering the changes in the PR. Ideally, we should run tests only if the changed files are related to source code or tests.
Solution:
The Jenkins pipeline reads the content of a file (e.g.,
.e2eignore
), containing file names and/or folder names and globbings one name per line. It proceeds to run the tests only if there is a modified file outside of that list.CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability