Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPSMDB-1172: fix special chars in backup user/password #1731

Merged
merged 11 commits into from
Dec 6, 2024
Merged

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Nov 19, 2024

K8SPSMDB-1172 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPSMDB-1172

DESCRIPTION

Problem:
Backup user password or username with special characters cause PBM to fail.

Cause:
PBM requires a percent-encoded URI.

Solution:
The operator must percent-encode usernames and passwords for the PBM_MONGODB_URI environment variable. These encoded usernames and passwords will be stored in an internal user secret, with each encoded value’s key appended with the _ESCAPED suffix.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/L 100-499 lines label Nov 19, 2024
@pull-request-size pull-request-size bot added size/XL 500-999 lines and removed size/L 100-499 lines labels Nov 21, 2024
@pooknull pooknull marked this pull request as ready for review November 21, 2024 17:52
@@ -134,7 +140,7 @@ func (r *ReconcilePerconaServerMongoDB) reconcileUsers(ctx context.Context, cr *
}
}

internalSysSecretObj.Data = sysUsersSecretObj.Data
internalSysSecretObj.Data = getInternalSecretData(&sysUsersSecretObj)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need 1.19.0 check here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

egegunes
egegunes previously approved these changes Nov 22, 2024
@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
custom-replset-name passed
custom-tls passed
custom-users-roles passed
custom-users-roles-sharded passed
cross-site-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-fs passed
demand-backup-eks-credentials-irsa passed
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded passed
expose-sharded passed
ignore-labels-annotations passed
init-deploy passed
finalizer passed
ldap passed
ldap-tls passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
multi-cluster-service passed
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-sharded passed
pitr-physical passed
pvc-resize passed
recover-no-primary passed
replset-overrides passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded-tls passed
upgrade-sharded passed
users passed
version-service passed
We run 53 out of 53

commit: 0a65f40
image: perconalab/percona-server-mongodb-operator:PR-1731-0a65f401

@hors hors merged commit ce91d21 into main Dec 6, 2024
8 of 13 checks passed
@hors hors deleted the dev/K8SPSMDB-1172 branch December 6, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL 500-999 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants