K8SPG-712: Allow overriding default configurations #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
egegunes
requested review from
hors,
pooknull,
nmarukovich and
gkech
as code owners
hors
previously approved these changes
Apr 3, 2025
gkech
reviewed
Apr 4, 2025
| "# Generated by postgres-operator. DO NOT EDIT.\n" + | ||
| "# Your changes will not be saved.\n" | ||
| "# Generated by postgres-operator. DO NOT EDIT UNLESS YOU KNOW WHAT YOU'RE DOING.\n" + | ||
| "# If you want to override the config, annotate this ConfigMap with " + naming.OverrideConfigAnnotation + "=true\n" |
Comment on lines
+73
to
+77
| // OverrideConfigAnnotation is an annotation used to prevent the controller from reconciling | ||
| // ConfigMaps when a user wants to manually override their contents. When this annotation | ||
| // is present, the controller will not update the ConfigMap, allowing users to make custom | ||
| // modifications that won't be overwritten during reconciliation. | ||
| OverrideConfigAnnotation = perconaAnnotationPrefix + "override-config" |
There was a problem hiding this comment.
Should we mention the ticket here as well?
| @@ -504,9 +507,22 @@ func (r *Reconciler) SetupWithManager(mgr manager.Manager) error { | |||
| } | |||
| } | |||
|
|
|||
| // K8SPG-712: Allow overriding default configurations | |||
| configMapPredicate := builder.WithPredicates(predicate.Funcs{ | |||
There was a problem hiding this comment.
Maybe we can cover this in our controller tests if it is not a major change for the controller_test.go file.
gkech
previously approved these changes
Apr 4, 2025
hors
approved these changes
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Our support team wants to have the ability to change all Patroni configuration options. For this we're introducing an annotation (
pgv2.percona.com/override-config) that if a ConfigMap has it, operator won't reconcile the ConfigMap. So you can annotate the ConfigMap and change any values in it. Beware that there's a sync period (~1m) after changing the ConfigMap and your changes to be reflected to file mounted to the container.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability