Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBM-1223] backup oplog from the oldest active transaction timestamp #900

Merged
merged 3 commits into from
Feb 28, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pbm/backup/backup.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
"github.com/percona/percona-backup-mongodb/pbm/errors"
"github.com/percona/percona-backup-mongodb/pbm/lock"
"github.com/percona/percona-backup-mongodb/pbm/log"
"github.com/percona/percona-backup-mongodb/pbm/oplog"
"github.com/percona/percona-backup-mongodb/pbm/storage"
"github.com/percona/percona-backup-mongodb/pbm/topo"
"github.com/percona/percona-backup-mongodb/pbm/util"
Expand Down Expand Up @@ -174,7 +175,7 @@ func (b *Backup) Run(ctx context.Context, bcp *ctrl.BackupCmd, opid ctrl.OPID, l
return errors.Wrap(err, "get cluster info")
}

oplogTS, err := topo.OpTimeFromNodeInfo(inf, true)
oplogTS, err := oplog.GetOplogStartTime(ctx, b.nodeConn)
if err != nil {
return errors.Wrap(err, "define oplog start position")
}
Expand Down Expand Up @@ -656,7 +657,7 @@ func (b *Backup) setClusterFirstWrite(ctx context.Context, bcpName string) error
return errors.New("no replset metadata")
}

if condAll(bcp.Replsets, func(br *BackupReplset) bool { return !br.FirstWriteTS.IsZero() }) {
if condAll(bcp.Replsets, func(br *BackupReplset) bool { return br.FirstWriteTS.T > 1 }) {
break
}

Expand Down
70 changes: 70 additions & 0 deletions pbm/oplog/oplog.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
package oplog

import (
"context"

"go.mongodb.org/mongo-driver/bson"
"go.mongodb.org/mongo-driver/bson/primitive"
"go.mongodb.org/mongo-driver/mongo"
"go.mongodb.org/mongo-driver/mongo/options"
"go.mongodb.org/mongo-driver/mongo/readconcern"

"github.com/percona/percona-backup-mongodb/pbm/errors"
)

var errNoTransaction = errors.New("no transaction found")

func GetOplogStartTime(ctx context.Context, m *mongo.Client) (primitive.Timestamp, error) {
ts, err := findTransactionStartTime(ctx, m)
if errors.Is(err, errNoTransaction) {
ts, err = findLastOplogTS(ctx, m)
defbin marked this conversation as resolved.
Show resolved Hide resolved
}

return ts, err
}

func findTransactionStartTime(ctx context.Context, m *mongo.Client) (primitive.Timestamp, error) {
coll := m.Database("config").Collection("transactions", options.Collection().SetReadConcern(readconcern.Local()))
f := bson.D{{"state", bson.D{{"$in", bson.A{"prepared", "inProgress"}}}}}
o := options.FindOne().SetSort(bson.D{{"startOpTime", 1}})
doc, err := coll.FindOne(ctx, f, o).Raw()
if err != nil {
if errors.Is(err, mongo.ErrNoDocuments) {
return primitive.Timestamp{}, errNoTransaction
}
return primitive.Timestamp{}, errors.Wrap(err, "query transactions")
}

rawTS, err := doc.LookupErr("startOpTime", "ts")
if err != nil {
return primitive.Timestamp{}, errors.Wrap(err, "lookup timestamp")
}

t, i, ok := rawTS.TimestampOK()
if !ok {
return primitive.Timestamp{}, errors.Wrap(err, "parse timestamp")
}

return primitive.Timestamp{T: t, I: i}, nil
}

func findLastOplogTS(ctx context.Context, m *mongo.Client) (primitive.Timestamp, error) {
coll := m.Database("local").Collection("oplog.rs")
o := options.FindOne().SetSort(bson.M{"$natural": -1})
doc, err := coll.FindOne(ctx, bson.D{}, o).Raw()
if err != nil {
return primitive.Timestamp{}, errors.Wrap(err, "query oplog")
}

rawTS, err := doc.LookupErr("ts")
if err != nil {
return primitive.Timestamp{}, errors.Wrap(err, "lookup oplog ts")
}

t, i, ok := rawTS.TimestampOK()
if !ok {
return primitive.Timestamp{}, errors.Wrap(err, "parse oplog ts")
}

return primitive.Timestamp{T: t, I: i}, nil
}
2 changes: 1 addition & 1 deletion pbm/oplog/restore.go
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ func bsonDocToOplog(doc bson.D) (*db.Oplog, error) {
func (o *OplogRestore) applyTxn(id string) error {
t, ok := o.txnData[id]
if !ok {
return errors.Errorf("unknown transaction id %s", id)
return nil
}

for _, op := range t.applyOps {
Expand Down
Loading