PBM-1588 Alicloud OSS Storage Implementation

[imrenagi]

HI,

I'm submitting pull request to add implement the feature proposal discussed in PBM-1588.

I have tested this storage implementation with storage test utility available on the project. Additionally, Im currently testing this storage implement to perform restoration on mongodb (backup creation and list are working). Please let me know if there is early feedback to this PR. It would be very appreciated.

Thanks!

[imrenagi]

hi @boris-ilijic @inelpandzic can you please help to review the change? TIA!

[boris-ilijic]

Hey @imrenagi , thanks a lot for your PR and contribution. We'll review it at some point, but first, we need to discuss the feature within the team and prioritize the Jira ticket. From the high level, PR looks good, but again, we'll need to go into details about it later. I appreciate your patience!

[imrenagi]

we need to discuss the feature within the team and prioritize the Jira ticket.

hi thanks for answer @boris-ilijic. Just want to understand the timeline, is there any plan on when this can be reviewed? Thanks!

[boris-ilijic]

Hey again @imrenagi!

The rough and unofficial plan is the following:

• It'll not be part of the next release (v2.11.0)
• We'll start to work on the review in 2-3 weeks from now, and soon after that it should be in main.
• It should be part of the next PBM release (v2.12.0) around December if everything goes well.

Again, this is still unofficial, and you'll be able to see more info within the ticket after we start to work on it.

[Copilot]

Pull Request Overview

This PR implements Alibaba Cloud Object Storage Service (OSS) support for the Percona Backup for MongoDB (PBM) project. The implementation follows the existing storage backend pattern and adds OSS as a new storage option alongside S3, GCS, Azure, and filesystem storage.

• Adds complete OSS storage backend implementation with multipart upload support
• Integrates OSS storage type into the storage factory and configuration system
• Includes comprehensive test coverage for the part size computation utility function

Reviewed Changes

Copilot reviewed 7 out of 114 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pbm/util/storage.go	Adds OSS import and factory case for creating OSS storage instances
pbm/storage/storage.go	Defines OSS storage type constant and parsing logic
pbm/storage/oss/oss.go	Main OSS storage implementation with all required storage operations
pbm/storage/oss/client.go	OSS client configuration and credential management
pbm/config/config.go	Integrates OSS configuration into the main config structure
pbm/storage/storage_test.go	Unit tests for the ComputePartSize utility function
go.mod	Adds required Alibaba Cloud OSS SDK dependencies

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The second and fifth parameters both pass 'o.cfg.UploadPartSize', but according to the ComputePartSize function signature, the second parameter should be 'defaultSize' and the fifth should be 'userSize'. This duplication appears incorrect.

[Copilot]

The credential masking logic modifies the original config struct. This should create a copy of the config before masking credentials to avoid mutating the original data, similar to how other storage types handle this.

[boris-ilijic]

Hi @imrenagi,

We'd like to proceed with your PR. Let's start with rebasing based on dev branch and cleaning up dependencies (go mod tidy).

There were some breaking changes in storage layer since you created PR:

• OSS will need to implement dummy DownloadStat method. You can copy the exact same implementation from here.
• It's necessary to wire up SplitMergeMiddleware (e.g. see here), but we can also do that during review.

After you push your updates, we'll start with review and testing, and the plan is to have that in dev branch asap, and to release it as part of v2.12.0.

Thank you again with your contribution.

[imrenagi]

hi @boris-ilijic . thanks. will try to update the PR today

[imrenagi]

@boris-ilijic I have updated the MR with the changes from go.mod and the DownloadStat method. However I'm not done with SplitMergeMiddleware. still trying to understand what that is.

So the New method from each storage implementation should return storage.Storage now instead of its actual object?