Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVEREST-1874 | support volume expansion for PXC #688

Merged
merged 25 commits into from
Mar 12, 2025

Conversation

mayankshah1607
Copy link
Member

@mayankshah1607 mayankshah1607 commented Mar 6, 2025

CHANGE DESCRIPTION

Problem:
EVEREST-1874

Allow PVC resizing (storage expansion) for PXC clusters:

  • set pxc.spec.enableVolumeExpansion=true when storage size is increased.
  • storage scaling may be prevented by setting db.spec.engine.storage.disableVolumeExpansion=true
  • add new DB state resizingVolumes
  • add a new conditions list in status to indicate failures related to storage resizing

CHECKLIST

Helm chart

  • Is the helm chart updated with the new changes? (if applicable)

Jira

  • Is the Jira ticket created and referenced properly?

Tests

  • Is an Integration test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
@mayankshah1607 mayankshah1607 added the test/e2e-core Run core E2E test suite label Mar 6, 2025
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
@mayankshah1607 mayankshah1607 marked this pull request as ready for review March 7, 2025 11:26
@mayankshah1607 mayankshah1607 requested a review from a team as a code owner March 7, 2025 11:26
@mayankshah1607 mayankshah1607 marked this pull request as draft March 7, 2025 11:42
@mayankshah1607 mayankshah1607 marked this pull request as ready for review March 7, 2025 11:53
@mayankshah1607 mayankshah1607 added the test/e2e Run full E2E test suite label Mar 10, 2025
Copy link
Contributor

@oksana-grishchenko oksana-grishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using conditions to describe the reasons looks good to me.
The idea of having the expansion enabled by default is also fine, I don't see any issues so far we could possibly face with it.
Approving the PR, left a couple of comment for consideration

Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
@mayankshah1607 mayankshah1607 changed the base branch from main to EVEREST-1870-fb March 11, 2025 09:57
@mayankshah1607 mayankshah1607 requested a review from recharte March 12, 2025 07:29
@mayankshah1607 mayankshah1607 requested review from oksana-grishchenko and recharte and removed request for recharte March 12, 2025 11:25
@mayankshah1607 mayankshah1607 merged commit e1446c0 into EVEREST-1870-fb Mar 12, 2025
4 of 5 checks passed
@mayankshah1607 mayankshah1607 deleted the EVEREST-1874 branch March 12, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test/e2e Run full E2E test suite test/e2e-core Run core E2E test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants