-
Notifications
You must be signed in to change notification settings - Fork 14
feat(inbox): Implement unified inbox with sign request notifications #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yasin-ce
wants to merge
20
commits into
multisig/07-creation-flow
Choose a base branch
from
multisig/08-inbox-pages
base: multisig/07-creation-flow
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
53f2564
chore(multisig): Miscellaneous updates and fixes
yasin-ce cd2fcb7
feat(multisig): Implement joint account creation flow
yasin-ce ec9a896
feat(multisig): Implement inbox pages for sign requests
yasin-ce 2954595
fix: Resolve merge conflicts and update domain model naming
yasin-ce 7466119
fix: Update app inbox mappers to use correct domain model names
yasin-ce 389afda
Merge branch 'multisig/07-creation-flow' into multisig/08-inbox-pages
yasin-ce 2d2d8b0
Fix JointAccountInvitationDetailFragment to use InboxApiRepository
yasin-ce 816af45
Merge branch 'multisig/07-creation-flow' into multisig/08-inbox-pages
yasin-ce d8a49ec
Merge branch 'multisig/07-creation-flow' into multisig/08-inbox-pages
yasin-ce db2437a
Merge branch 'multisig/07-creation-flow' into multisig/08-inbox-pages
yasin-ce 4592163
fix: Address PR #518 review comments
yasin-ce d0a7bfa
refactor: Use TimeProvider and RelativeTimeDifference in SignatureReq…
yasin-ce ed0641d
refactor: Move deep link handling flag to ViewModel and implement Inb…
yasin-ce 0e0a8b0
refactor: Move account display logic to JointAccountInvitationDetailV…
yasin-ce d8d0d97
refactor: Simplify InboxScreenPreview by using StateFlow overload
yasin-ce 03876f2
refactor: Fix InboxLastOpenedTimeLocalSource DI with PersistentCacheP…
yasin-ce 0d6583f
refactor: Implement ViewState/ViewEvent pattern for Inbox
yasin-ce 13d3ab6
fix: Address PR review feedback and add coding rules
yasin-ce 31bfdc0
fix: Address PR review feedback and add coding rules
yasin-ce 5603799
Merge branch 'multisig/08-inbox-pages' of github.com:perawallet/pera-…
yasin-ce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,3 +46,6 @@ render.experimental.xml | |
|
|
||
| # Claude | ||
| .claude/ | ||
|
|
||
| # Backend Feedback | ||
| BACKEND_FEEDBACK.md | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
...rc/main/kotlin/com/algorand/android/modules/inbox/allaccounts/di/InboxRepositoryModule.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * Copyright 2022-2025 Pera Wallet, LDA | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License | ||
| */ | ||
|
|
||
| package com.algorand.android.modules.inbox.allaccounts.di | ||
|
|
||
| import com.algorand.android.modules.inbox.allaccounts.ui.mapper.InboxPreviewMapper | ||
| import com.algorand.android.modules.inbox.allaccounts.ui.mapper.InboxPreviewMapperImpl | ||
| import dagger.Module | ||
| import dagger.Provides | ||
| import dagger.hilt.InstallIn | ||
| import dagger.hilt.components.SingletonComponent | ||
| import javax.inject.Singleton | ||
|
|
||
| @Module | ||
| @InstallIn(SingletonComponent::class) | ||
| object InboxRepositoryModule { | ||
|
|
||
| @Provides | ||
| @Singleton | ||
yasin-ce marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| fun provideInboxPreviewMapper( | ||
| inboxPreviewMapperImpl: InboxPreviewMapperImpl | ||
| ): InboxPreviewMapper = inboxPreviewMapperImpl | ||
| } | ||
36 changes: 36 additions & 0 deletions
36
...in/kotlin/com/algorand/android/modules/inbox/allaccounts/domain/model/InboxWithAccount.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * Copyright 2022-2025 Pera Wallet, LDA | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License | ||
| */ | ||
|
|
||
| package com.algorand.android.modules.inbox.allaccounts.domain.model | ||
|
|
||
| import android.os.Parcelable | ||
| import com.algorand.android.models.RecyclerListItem | ||
| import com.algorand.android.modules.accountcore.ui.model.AccountDisplayName | ||
| import com.algorand.android.modules.accounticon.ui.model.AccountIconDrawablePreview | ||
| import kotlinx.parcelize.Parcelize | ||
|
|
||
| @Parcelize | ||
| data class InboxWithAccount( | ||
| val address: String, | ||
| val requestCount: Int, | ||
| val accountDisplayName: AccountDisplayName, | ||
| val accountAddress: String, | ||
| val accountIconDrawablePreview: AccountIconDrawablePreview | ||
| ) : Parcelable, RecyclerListItem { | ||
| override fun areItemsTheSame(other: RecyclerListItem): Boolean { | ||
| return other is InboxWithAccount && accountAddress == other.accountAddress | ||
| } | ||
|
|
||
| override fun areContentsTheSame(other: RecyclerListItem): Boolean { | ||
| return other is InboxWithAccount && this == other | ||
| } | ||
| } |
42 changes: 42 additions & 0 deletions
42
.../com/algorand/android/modules/inbox/allaccounts/domain/model/SignatureRequestInboxItem.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| /* | ||
| * Copyright 2022-2025 Pera Wallet, LDA | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License | ||
| */ | ||
|
|
||
| package com.algorand.android.modules.inbox.allaccounts.domain.model | ||
|
|
||
| import android.os.Parcelable | ||
| import com.algorand.android.models.RecyclerListItem | ||
| import com.algorand.android.modules.accounticon.ui.model.AccountIconDrawablePreview | ||
| import kotlinx.parcelize.Parcelize | ||
|
|
||
| @Parcelize | ||
| data class SignatureRequestInboxItem( | ||
| val signRequestId: String, | ||
| val jointAccountAddress: String, | ||
| val jointAccountAddressShortened: String, | ||
| val accountIconDrawablePreview: AccountIconDrawablePreview, | ||
| val description: String, | ||
| val timeAgo: String, | ||
| val signedCount: Int, | ||
| val totalCount: Int, | ||
| val timeLeft: String?, | ||
| val isRead: Boolean = true, | ||
| val isExpired: Boolean = false, | ||
| val canUserSign: Boolean = true | ||
| ) : Parcelable, RecyclerListItem { | ||
| override fun areItemsTheSame(other: RecyclerListItem): Boolean { | ||
| return other is SignatureRequestInboxItem && signRequestId == other.signRequestId | ||
| } | ||
|
|
||
| override fun areContentsTheSame(other: RecyclerListItem): Boolean { | ||
| return other is SignatureRequestInboxItem && this == other | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.