Skip to content

[BACKLOG-48717] - list & test project support#1350

Open
abryant-hv wants to merge 1 commit intomasterfrom
abryant/BACKLOG-48717
Open

[BACKLOG-48717] - list & test project support#1350
abryant-hv wants to merge 1 commit intomasterfrom
abryant/BACKLOG-48717

Conversation

@abryant-hv
Copy link
Copy Markdown
Contributor

  • add "allLevels" parameter
  • add "level" to response database objects in list call
  • support Variables in test

@abryant-hv abryant-hv requested a review from a team as a code owner April 2, 2026 19:52
Copilot AI review requested due to automatic review settings April 2, 2026 19:52
- add "allLevels" parameter
- add "level" to response database objects in list call
- support Variables in test
@abryant-hv abryant-hv force-pushed the abryant/BACKLOG-48717 branch from a2d7714 to df798e7 Compare April 2, 2026 19:54
@buildguy

This comment has been minimized.

@buildguy
Copy link
Copy Markdown
Collaborator

buildguy commented Apr 2, 2026

❌ Build failed in 1m 17s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl api,core

❗ No tests found!

Errors:

Filtered log (click to expand)

script returned exit code 1

ℹ️ This is an automatic message

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the connections REST API to support an allLevels query parameter, adds a level field to connection list results, and introduces variable substitution when testing connections.

Changes:

  • Add allLevels query parameter to the list connections endpoint and extend the service method signature accordingly.
  • Set a level field on returned connections (currently always "Repository").
  • Add variable substitution support for testConnection via a new DatabaseConnectionUtils helper and accompanying tests.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
core/src/main/java/org/pentaho/platform/dataaccess/datasource/wizard/service/impl/ConnectionService.java Adds variable substitution during testConnection, introduces allLevels in getConnections, and sets level on returned connections.
core/src/main/java/org/pentaho/platform/dataaccess/datasource/utils/DatabaseConnectionUtils.java New utility to apply Kettle variable substitution across connection fields (including partitions and pooling props).
core/src/test/java/org/pentaho/platform/dataaccess/datasource/wizard/service/impl/ConnectionServiceRestApiTest.java Adds tests for variable substitution on testConnection and for level being present on list responses.
core/src/test/java/org/pentaho/platform/dataaccess/datasource/utils/DatabaseConnectionUtilsTest.java New unit tests covering substitution behavior across many connection fields and edge cases.
api/src/main/resources/connection-api.yaml Documents the new allLevels query parameter and adds the level field to the schema.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants