[BACKLOG-48717] - list & test project support#1350
Open
abryant-hv wants to merge 1 commit intomasterfrom
Open
Conversation
Contributor
abryant-hv
commented
Apr 2, 2026
- add "allLevels" parameter
- add "level" to response database objects in list call
- support Variables in test
- add "allLevels" parameter - add "level" to response database objects in list call - support Variables in test
a2d7714 to
df798e7
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
❌ Build failed in 1m 17sBuild command: mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl api,core❗ No tests found!Errors:Filtered log (click to expand)
ℹ️ This is an automatic message |
There was a problem hiding this comment.
Pull request overview
This PR extends the connections REST API to support an allLevels query parameter, adds a level field to connection list results, and introduces variable substitution when testing connections.
Changes:
- Add
allLevelsquery parameter to the list connections endpoint and extend the service method signature accordingly. - Set a
levelfield on returned connections (currently always"Repository"). - Add variable substitution support for
testConnectionvia a newDatabaseConnectionUtilshelper and accompanying tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/main/java/org/pentaho/platform/dataaccess/datasource/wizard/service/impl/ConnectionService.java | Adds variable substitution during testConnection, introduces allLevels in getConnections, and sets level on returned connections. |
| core/src/main/java/org/pentaho/platform/dataaccess/datasource/utils/DatabaseConnectionUtils.java | New utility to apply Kettle variable substitution across connection fields (including partitions and pooling props). |
| core/src/test/java/org/pentaho/platform/dataaccess/datasource/wizard/service/impl/ConnectionServiceRestApiTest.java | Adds tests for variable substitution on testConnection and for level being present on list responses. |
| core/src/test/java/org/pentaho/platform/dataaccess/datasource/utils/DatabaseConnectionUtilsTest.java | New unit tests covering substitution behavior across many connection fields and edge cases. |
| api/src/main/resources/connection-api.yaml | Documents the new allLevels query parameter and adds the level field to the schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...n/java/org/pentaho/platform/dataaccess/datasource/wizard/service/impl/ConnectionService.java
Show resolved
Hide resolved
.../src/main/java/org/pentaho/platform/dataaccess/datasource/utils/DatabaseConnectionUtils.java
Show resolved
Hide resolved
.../test/java/org/pentaho/platform/dataaccess/datasource/utils/DatabaseConnectionUtilsTest.java
Show resolved
Hide resolved
...pentaho/platform/dataaccess/datasource/wizard/service/impl/ConnectionServiceRestApiTest.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.