Fix project handling #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the rebase abort due to some merge conflicts the value of 'project' is lost. Fix it by making it a global variable and save it in case of an error during the bailout() step. Signed-off-by: Marco Felsch <[email protected]>
|
@kbingham can you confirm that this fixes the issue you faced with libcamera? |
|
Yes, just re-ran the umpf running this commit (with a merge conflict resolution step required) and it worked with the correct version separator marker. |
|
Nope - I take it back ... something went wrong.... Debugging |
|
Re-run - and now it's working. I think I probably had the stale/old umpf state in the .git/umpf dir when I swapped to the mfe/libcamera-fix branch ... perhaps ... ? Anyway, I'm pretty sure this pr is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the rebase step abort due to some merge conflicts the value of 'project' is lost. Fix it by making it a global variable and save it in case of an error during the bailout() step.